logs: Change log-level of output folder destination #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the verbosity of the log message when writing output files by changing its level from info to debug.
- Changed the log level for output path messages
- Ensures quieter default logging during routine output writes
Comments suppressed due to low confidence (2)
src/routines/output.rs:97
- [nitpick] Consider updating module-level documentation or release notes to reflect that the output path message is now logged at debug level, so users can adjust their log filters accordingly.
tracing::debug!("Writing outputs to {:?}", self.settings.output().path);
src/routines/output.rs:97
- [nitpick] Consider adding a unit or integration test to verify that this log message appears at debug level, ensuring the intended log level behavior is maintained.
tracing::debug!("Writing outputs to {:?}", self.settings.output().path);
|
Bencher Report| Branch | log-level-outputs |
| Testbed | orion |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_fit | 📈 view plot 🚷 view threshold | 9.82 s(-34.40%)Baseline: 14.96 s | 26.47 s (37.09%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.